-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic removal of blocks #139
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
===========================================
+ Coverage 60.73% 80.75% +20.02%
===========================================
Files 16 16
Lines 1663 1663
===========================================
+ Hits 1010 1343 +333
+ Misses 653 320 -333 ☔ View full report in Codecov by Sentry. |
Note @nbenn: I can also make |
@DivadNojnarg You could also not export the generic function itself I believe. The corresponding (class-specific) methods have to be exported, but as long as the generic is not, it should behave as "interal" function, despite using s3 dispatch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections from my side.
Great @nbenn. I am done with this PR. This can go to main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
Will fix one of the issue in #136, where the remove button is missing for dynamically added blocks.