Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will fix Crash due to validation issue #101 #116

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Conversation

DivadNojnarg
Copy link
Collaborator

No description provided.

@DivadNojnarg DivadNojnarg requested a review from nbenn as a code owner December 4, 2023 09:46
@DivadNojnarg DivadNojnarg marked this pull request as draft December 4, 2023 09:50
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7ffc548) 57.53% compared to head (860eff9) 72.84%.
Report is 6 commits behind head on main.

Files Patch % Lines
R/field.R 87.50% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #116       +/-   ##
===========================================
+ Coverage   57.53%   72.84%   +15.31%     
===========================================
  Files          15       15               
  Lines        1639     1650       +11     
===========================================
+ Hits          943     1202      +259     
+ Misses        696      448      -248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DivadNojnarg DivadNojnarg marked this pull request as ready for review December 4, 2023 10:04
Copy link
Collaborator

@nbenn nbenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether this does not introduce other potential bugs? Maybe wrap the comparisons with isTRUE() to be sure?

@DivadNojnarg
Copy link
Collaborator Author

@nbenn. I am done here and I left few comments here to revisit validation at a later point which is the main problem.

@DivadNojnarg
Copy link
Collaborator Author

@nbenn : can we merge this one. I can't continue #119 because of the crash (makes a server test failing).

@nbenn
Copy link
Collaborator

nbenn commented Dec 8, 2023

@DivadNojnarg Sorry. Try again?

@DivadNojnarg DivadNojnarg merged commit 17ca711 into main Dec 8, 2023
@DivadNojnarg DivadNojnarg deleted the 101-validation-crash branch December 13, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants