Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mocha now that wct-mocha is fixed #120

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

svanherk
Copy link
Contributor

Now that Polymer/tools#3394 (comment) is fixed, we can also get mocha onto the latest and remove the greenkeeper ignore settings.

@svanherk
Copy link
Contributor Author

To note: This build failed the first time on a hover visual diff test, I think it was a race condition: https://s3.ca-central-1.amazonaws.com/visualdiff.gaudi.d2l/screenshots/button-icon/2019-06-12%2016.41.16.14/report.html

Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@svanherk svanherk merged commit 866afb5 into dbatiste/update-eslint-config Jun 12, 2019
@svanherk svanherk deleted the Update_mocha branch June 12, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants