Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: node: [16.x, 18.x, 20.x] #905

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 23, 2023

Let's try to get brain.js tests passing on current versions of Node.js. https://github.com/nodejs/release#readme

brain.js/package-lock.json

Lines 11483 to 11484 in 2268193

"node_modules/node-gyp": {
"version": "7.1.2",
vs. v9.4.0 at https://github.com/nodejs/node-gyp/releases

A GIF or MEME to give some spice of the internet

Description

Motivation and Context

issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfy the motivation.

@robertleeplummerjr Your review, please.
@kul-sudo FYI

@cclauss cclauss changed the title GitHub Actions: node: ['16.x', '18.x', '20.x'] GitHub Actions: node: [16.x, 18.x, 20.x] Jul 24, 2023
Copy link
Contributor

@robertleeplummerjr robertleeplummerjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertleeplummerjr robertleeplummerjr merged commit b39ef9f into BrainJS:master Dec 6, 2023
@cclauss cclauss deleted the patch-1 branch December 6, 2023 15:00
@cclauss
Copy link
Contributor Author

cclauss commented Dec 6, 2023

macOS failures are fixed by upgrading to the current https://github.com/nodejs/node-gyp/releases

@robertleeplummerjr
Copy link
Contributor

Could you put in a PR that has this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants