GitHub Actions: node: [16.x, 18.x, 20.x] #905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try to get brain.js tests passing on current versions of Node.js. https://github.com/nodejs/release#readme
libxi-dev
and friends on Ubuntu -- https://github.com/BrainJS/brain.js#installation-noterm package-lock.json
because it was using an out-of-date version ofnode-gyp
npm clean
for Windows, etc.brain.js/package-lock.json
Lines 11483 to 11484 in 2268193
Description
Motivation and Context
issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Author's Checklist:
Reviewer's Checklist:
@robertleeplummerjr Your review, please.
@kul-sudo FYI