Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 925: Fix broken example links #24

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

apophis51
Copy link
Contributor

Some of the example links are broken on https://brain.js.org/#/examples, so I'm making this pull request in response to BrainJS/brain.js#925

a chore update BrainJS/brain.js@812b27d broke all the following links which I updated on the 'store':

  • Using node streams
    github.com/BrainJS/brain.js/blob/master/examples/javascript/stream-example.js
    updated to -> github.com/BrainJS/brain.js-examples/blob/main/src/stream-example.ts

  • Forecasting
    github.com/BrainJS/brain.js/blob/master/examples/javascript/predict-numbers.js
    updated to -> github.com/BrainJS/brain.js-examples/blob/main/src/predict-numbers.ts

  • Maths
    github.com/BrainJS/brain.js/blob/master/examples/javascript/learn-math.js
    updated to -> github.com/BrainJS/brain.js-examples/blob/main/src/learn-math.ts

  • Cross Validate
    github.com/BrainJS/brain.js/blob/master/examples/javascript/cross-validate.js
    updated to -> github.com/BrainJS/brain.js-examples/blob/main/src/cross-validate.ts

  • GPU powered AI
    github.com/BrainJS/brain.js/blob/master/examples/javascript/gpu.html
    updated to -> github.com/BrainJS/brain.js-examples/blob/main/src/feed-forward-gpu-xor.ts

Also For some reason "using node streams" was repeated twice (there were two duplicate links side-by-side on site) so i removed that duplicate

Unfortunately I only can update to the typescript examples because the js examples were never coppied when that chore was completed. Maybe we add the js links back in a future update we can then have the links just point to both the .ts and .js versions. At least the examples wont be broken for now

@mubaidr mubaidr merged commit 8f39854 into BrainJS:master Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants