Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack implementation in JavaScript #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

richardartoul
Copy link
Collaborator

Hey guys,

I added a Javascript implementation for stacks. I have a question before merging:

The JavaScript testing system seems to run all the code samples through Node (after injecting the assert library) whereas the Python testing system runs the separate unit test files. How do you want me to handle testing the JavaScript stuff? I think it'll look weird if we have assert statements in all the JavaScript code samples, but not in the Python code samples. Its not the end of the world though. Would you rather I continue doing that (in which case I'll add tests to this pull request) or that I set up some generic JavaScript testing system we can use?

@ozan
Copy link
Contributor

ozan commented Apr 19, 2016

I actually like the asserts when they serve an illustrative purpose for the reader. I haven't yet encountered a situation where I wanted JavaScript tests that were not also illustrative for the reader, but only at that point would I set up some other js testing system. Up to you though.

Regarding the CI fail, you'll need to add the gross "coding" magic comment # -*- coding: utf-8 -*-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants