Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving deque implementation to its own file #113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bharatagarwal
Copy link
Contributor

This moves the deque implementation to its own file. Also fixed a typo involving a missing backtick in the table demonstration deque operations.

Note: Removed (object) from class declaration along the lines of #112

@bharatagarwal bharatagarwal changed the title Deque implementation own file Moving deque implementation to its own file Sep 13, 2023
Copy link
Collaborator

@robot-dreams robot-dreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

Comment on lines +5 to +26
cases = (
(lambda d: d.is_empty(), [], True),
(lambda d: d.add_rear(4), [4], None),
(lambda d: d.add_rear('dog'), ['dog', 4], None),
(lambda d: d.add_front('cat'), ['dog', 4, 'cat'], None),
(lambda d: d.add_front(True), ['dog', 4, 'cat', True], None),
(lambda d: d.size(), ['dog', 4, 'cat', True], 4),
(lambda d: d.is_empty(), ['dog', 4, 'cat', True], False),
(lambda d: d.add_rear(8.4), [8.4, 'dog', 4, 'cat', True], None),
(lambda d: d.remove_rear(), ['dog', 4, 'cat', True], 8.4),
(lambda d: d.remove_front(), ['dog', 4, 'cat'], True)
)


class TestCorrectness(unittest.TestCase):

def test_operates_correctly(self):
deque = Deque()
for operate, expected_state, expected_return in cases:
actual_return = operate(deque)
self.assertEqual(actual_return, expected_return)
self.assertEqual(deque._items, expected_state)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about something like this instead?

cases = (
    (Deque.is_empty, [], [], True),
    (Deque.add_rear, [4], [4], None),
    (Deque.add_rear, ['dog'], ['dog', 4], None),
    (Deque.add_front, ['cat'], ['dog', 4, 'cat'], None),
    (Deque.add_front, [True], ['dog', 4, 'cat', True], None),
    (Deque.size, [], ['dog', 4, 'cat', True], 4),
    (Deque.is_empty, [], ['dog', 4, 'cat', True], False),
    (Deque.add_rear, [8.4], [8.4, 'dog', 4, 'cat', True], None),
    (Deque.remove_rear, [], ['dog', 4, 'cat', True], 8.4),
    (Deque.remove_front, [], ['dog', 4, 'cat'], True)
)


class TestCorrectness(unittest.TestCase):

    def test_operates_correctly(self):
        deque = Deque()
        for method, args, expected_state, expected_return in cases:
            actual_return = method(deque, *args)
            self.assertEqual(actual_return, expected_return)
            self.assertEqual(deque._items, expected_state)

book/deques/deque.py Outdated Show resolved Hide resolved
Co-authored-by: Elliott Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants