Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable searching bulk transfer uploads by token address #705

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Enable searching bulk transfer uploads by token address #705

merged 1 commit into from
Oct 3, 2024

Conversation

YoshihitoAso
Copy link
Member

close #704

@YoshihitoAso YoshihitoAso marked this pull request as ready for review October 3, 2024 11:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
app/model/schema
   __init__.py200100% 
   bulk_transfer.py480100% 
app/routers/issuer
   bond.py11391199%719, 1131, 2126, 2338, 2502, 2799, 2807, 3747–3750
   share.py11211199%686, 1098, 2054, 2266, 2430, 2730, 2738, 3677–3680
tests/app
   test_bond_bulk_transfer_ListBondTokenBulkTransfers.py1400100% 
   test_share_bulk_transfer_ListShareTokenBulkTransfers.py1400100% 
TOTAL75886124798% 

Tests Skipped Failures Errors Time
1940 0 💤 0 ❌ 0 🔥 23m 42s ⏱️

purplesmoke05
purplesmoke05 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@purplesmoke05 purplesmoke05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshihitoAso YoshihitoAso merged commit 351b97d into dev-24.12 Oct 3, 2024
10 checks passed
@YoshihitoAso YoshihitoAso deleted the feature/#704 branch October 3, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purplesmoke05 purplesmoke05 purplesmoke05 approved these changes

Assignees

@YoshihitoAso YoshihitoAso

@ouchikai ouchikai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a token_address parameter to the query of the BulkTransferUpload list retrieval API
3 participants
@YoshihitoAso @purplesmoke05 @ouchikai