Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SealedTx feature #695

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add SealedTx feature #695

merged 1 commit into from
Sep 30, 2024

Conversation

YoshihitoAso
Copy link
Member

@YoshihitoAso YoshihitoAso commented Sep 30, 2024 •
edited
Loading

close #689

Add SealedTx feature 🚀

  • As a simple implementation, I decided to overwrite the data of PersonalInfo if it already exists.
  • Therefore, if there is a delay in reflecting on-chain information, it is possible that it may be overwritten again by the on-chain information. However, since it seems there are no use cases that utilize both on-chain and off-chain transactions, I have decided not to consider this for now.

@github-actions GitHub Actions
Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
__init__.py00100% 
sealedtx_utils.py37294%49, 64
misc
   sealed_tx.py270100% 
schema
   __init__.py200100% 
   sealed_tx.py80100% 
TOTAL13183113991% 

Tests Skipped Failures Errors Time
1932 0 💤 0 ❌ 0 🔥 35m 53s ⏱️

@YoshihitoAso YoshihitoAso merged commit 69b9a86 into dev-24.12 Sep 30, 2024
7 checks passed
@YoshihitoAso YoshihitoAso deleted the feature/#689 branch September 30, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purplesmoke05 purplesmoke05 purplesmoke05 approved these changes

Assignees

@YoshihitoAso YoshihitoAso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] "SealedTx": Off-chain personal information registration
2 participants
@YoshihitoAso @purplesmoke05