fix: Added a specific dimension to logo and web-font display swap #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,7 +28,7 @@ | |||
| <meta name="twitter:description" content="" /> | |||
| <meta name="twitter:image" content="img/logo.png" /> | |||
|
|
|||
| <link rel="icon" href="img/logo.png" alt="Image Search App Logo" type="image/png" sizes="512X512"> | |||
| <link rel="icon" href="img/logo.png" alt="Image Search App Logo" type="image/png" width="300" height="300"> | |||
There was a problem hiding this comment.
Someone is already fixing this in #35. Can you remove the changes for this part, please?
BolajiAyodeji
requested changes
Jan 27, 2023
| @@ -1,4 +1,4 @@ | |||
| @import url('https://fonts.googleapis.com/css?family=Roboto+Mono:100,300,400'); | |||
| @import url('https://fonts.googleapis.com/css?family=Roboto+Mono:100,300,400&display=swap'); | |||
There was a problem hiding this comment.
Looks good to me!
Please take a look at my other comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a specific dimension to the logo of the homepage; also a display font swap to avoid text being invisible during web-font load.