Docker support #73
Open
Docker support #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoo
force-pushed
the
feature/docker
branch
2 times, most recently
from
281641e to
b305b83
Compare
|
updated docker-compose config |
…ure/docker * 'feature/docker' of github.com:idoo/codecrumbs: (61 commits) feat: added basic Docker fix: build 1.7.3 fix: docs fix: readme change chore: clean up 1.7.2 fix: saga feat: hide source tree feat: add file path to code preview feat: add file path to code preview fix: underlay styles for namespace title 1.7.1 fix: peformance for flow steps 1.7.0 1.6.18 fix: left margin for svg fix: readme 1.6.17 fix: config file support ...
mandrean
suggested changes
Sep 9, 2019
| WORKDIR /usr/src/app | ||
|
|
||
| # Install app dependencies | ||
| COPY package*.json ./ |
There was a problem hiding this comment.
Add the yarn lock file in this step as well to improve build caching
There was a problem hiding this comment.
Ah the repo doesn’t lock down the transitive dependencies.
Maybe @Bogdan-Lyashenko can explain his reasoning behind it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.