Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): add gcp provider with data #372

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonperron
Copy link
Contributor

@jonperron jonperron commented Feb 4, 2025

Changelog

  • Update providers.csv
  • Add data from gcp with documentation links

Fix #145

@jonperron
Copy link
Contributor Author

Two remaining questions:

Changelog
* Update providers.csv
* Add data from gcp with documentation links
@jonperron jonperron force-pushed the feat/boaviztapi-145 branch from 771b7de to 3b6c2c8 Compare February 4, 2025 16:55
@da-ekchajzer
Copy link
Collaborator

What "platform" means in this context ?

The platform is the bare metal server that hosts the instance. Since we are calculating the impact of the instance as part of the bare metal server, we need to know its architecture. The platform field must match one of the id's of the available server archetypes. So you should add a platform name that matches a platform you are going to create in boaviztapi/data/archetypes/server.csv. This documentation may help you:

It is always difficult to get all the data, so sometimes you will have to guess. If so, you should mention it in the warning column. I recommend that you set the CPU name so that the other values are automatically filled in at runtime. If you do this, make sure the CPU is listed in the CPU data file. If it is not listed, you should add it so that everyone can benefit from it: https://doc.api.boavizta.org/contributing/cpu/.

The most important values are :

  • CPU.vcpu
  • case_type (always rack in cloud contexte)
  • CPU.units
  • SSD.units
  • SSD.capacity
  • HDD.units
  • HDD.capacity

For POWER_SUPPLY and USAGE feel free to use the values from the other providers.

GCP has a couple of GPU machine types (https://cloud.google.com/compute/docs/gpus?hl=en), with a range of vcpus and ram. How should they be taken into account ?

We believe that GPUs are never shared between instances, so there is no need to include the resources in the instance file. However, you can add the data to the server.csv. For know we are not calculating the impact of GPU but we will be soon so I recommend you to add it.

Hope this is clear, if not ping me on mattermost.

@jonperron jonperron marked this pull request as draft February 5, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP cloud instances
2 participants