Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/refactor cloud instance #255

Merged
merged 27 commits into from
Jan 15, 2024
Merged

Feat/refactor cloud instance #255

merged 27 commits into from
Jan 15, 2024

Conversation

da-ekchajzer
Copy link
Collaborator

@da-ekchajzer da-ekchajzer commented Dec 16, 2023

This PR follows this discussion : #252

Improvements

  • Externalizing impacts computation outside the asset's model by creating a service for this purpose (boaviztapi/service/impacts_computation.py)
  • Updating cloud instance model and impacts computation in line with : Proposition to refactor cloud instance models and data #252 (comment)
  • Improve impact mode (boaviztapi/model/impact.py)l. All the assets keep the impacts as an attribute once they have been calculated. Performance is significantly improved in the event of a verbose call (which would lead to impacts being recalculated).
  • Fixed a bug I discovered by accident: power consumption was modelled for one component unit. Consumption was only multiplied by the number of components when calculating impacts at device level. The consumption of the component now reflects the consumption of all the units.

TODO

da-ekchajzer added a commit that referenced this pull request Dec 26, 2023
da-ekchajzer added a commit that referenced this pull request Dec 26, 2023
@da-ekchajzer
Copy link
Collaborator Author

We have done all the item on the to-do list. I leave you sometime to review all the modifications.

@samuelrince
Copy link
Member

I think we can merge this one :) @da-ekchajzer

@da-ekchajzer da-ekchajzer merged commit 25471b6 into dev Jan 15, 2024
1 check passed
@da-ekchajzer da-ekchajzer deleted the feat/refactor_cloud_instance branch October 11, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants