-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/refactor cloud instance #255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l_power_consumption
da-ekchajzer
added a commit
that referenced
this pull request
Dec 26, 2023
da-ekchajzer
added a commit
that referenced
this pull request
Dec 26, 2023
We have done all the item on the to-do list. I leave you sometime to review all the modifications. |
This was referenced Dec 27, 2023
I think we can merge this one :) @da-ekchajzer |
samuelrince
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows this discussion : #252
Improvements
TODO
Complete the file /data/archetypes/cloud/aws.csv with the new formatdone by @samuelrinceComplete the /data/archetypes/server.csv file with the platforms mentioned in the aws.csv filedone by @samuelrinceComplete the /data/archetypes/server.csv file with finer-grained generic serversdone by @samuelrinceRewriting tests for the clouddone by @da-ekchajzerCreate documentation on adding new instances (see Doc : How to contribute to add new cloud instances, providers and CPU #250)done by @da-ekchajzer see Doc : How to contribute to add new cloud instances, providers and CPU #250