-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught exception to include CORS middleware #243
Conversation
3ac9b45
to
0ff2882
Compare
0ff2882
to
c02e493
Compare
Thank you very much for your PR. Would it be possible to log the stack trace when error is catch ? |
@da-ekchajzer Do we need to include any kind of logging set up or is this sufficient? |
Ok for me Thanks for this update, we can consider #240 solved. I am not familiar with error handling in starlette, but the logger logs the following error before logging the excpeted error.
I don't think it's an important problem, but just checking if you have any idea on the reason of this error. |
I noticed the same thing. I'm quite new to Python, but I think this is an issue with how Starlette is handling the errors in anyio.memory.MemoryObjectReceiveStream. What I've done is remove this context from the traceback if the context of the Exception is anyio.EndOfStream. |
Great, thank you very much for your contribution. |
To resolve #240