Add Unit Test #20
Closed
Add Unit Test #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @egonw - I have added unit test case for below mentioned file.
Kindly review and provide feedback if any. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
============================================
+ Coverage 32.47% 33.23% +0.76%
- Complexity 3369 3456 +87
============================================
Files 280 280
Lines 31409 31409
Branches 6299 6299
============================================
+ Hits 10199 10439 +240
+ Misses 19513 19247 -266
- Partials 1697 1723 +26 ☔ View full report in Codecov by Sentry. |
egonw
requested changes
Oct 7, 2023
src/test/java/org/xmlcml/cml/element/main/CMLDictionaryTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/xmlcml/cml/element/main/CMLIdentifierTest.java
Outdated
Show resolved
Hide resolved
|
Hi @egonw, Added the requested changes. |
|
Merged into the 4.7 dev branch: #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.