Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SymPy errors when using reserved symbols in differentiate2c #1531

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Oct 23, 2024

No description provided.

The user should now make sure to pass all of the symbols to the function
as SymPy objects.
@JCGoran JCGoran marked this pull request as ready for review October 24, 2024 11:24
@JCGoran JCGoran changed the title Fix SymPy errors when using reserved symbols Fix SymPy errors when using reserved symbols in differentiate2c Oct 24, 2024
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There already code for renaming, e.g. search for forbidden_var. How to the two fit together and why do we need the duplication?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants