Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-packaging #1108

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Add check-packaging #1108

merged 6 commits into from
Mar 27, 2024

Conversation

eleftherioszisis
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Merging #1108 (e9af142) into master (5630294) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1108   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         2450      2450           
=========================================
  Hits          2450      2450           

pyproject.toml Outdated
@@ -59,7 +59,11 @@ Tracker = "https://github.com/BlueBrain/NeuroM/issues"
neurom = 'neurom.apps.cli:cli'

[tool.setuptools.packages.find]
include = ["neurom"]
where = ["."]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check the sdist to see everything worked?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be where = ["neurom*"] to avoid including tests and other random stuffs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to that. Both include and where seem to work. With the latest changes I get:
wheel:

.
├── apps
│   ├── annotate.py
│   ├── cli.py
│   ├── config
│   │   ├── morph_check.yaml
│   │   └── morph_stats.yaml
│   ├── __init__.py
│   ├── morph_check.py
│   └── morph_stats.py
├── check
│   ├── __init__.py
│   ├── morphology_checks.py
│   ├── morphtree.py
│   ├── neuron_checks.py
│   └── runner.py
├── core
│   ├── dataformat.py
│   ├── __init__.py
│   ├── morphology.py
│   ├── neuron.py
│   ├── population.py
│   ├── soma.py
│   └── types.py
├── features
│   ├── bifurcationfunc.py
│   ├── bifurcation.py
│   ├── __init__.py
│   ├── morphology.py
│   ├── neurite.py
│   ├── population.py
│   ├── sectionfunc.py
│   └── section.py
├── geom
│   ├── __init__.py
│   └── transform.py
├── io
│   ├── __init__.py
│   └── utils.py
├── neurom-3.2.9.dev5.dist-info
│   ├── AUTHORS.md
│   ├── entry_points.txt
│   ├── LICENSE.txt
│   ├── METADATA
│   ├── RECORD
│   ├── top_level.txt
│   └── WHEEL
└── view
    ├── dendrogram.py
    ├── __init__.py
    ├── matplotlib_impl.py
    ├── matplotlib_utils.py
    └── plotly_impl.py

source tar:

.
├── asv.conf.json
├── AUTHORS.md
├── CHANGELOG.rst
├── doc
│   ├── clean.sh
│   ├── make.bat
│   ├── Makefile
│   └── source
│       ├── api.rst
│       ├── changelog.rst
│       ├── cli.rst
│       ├── conf.py
│       ├── definitions.rst
│       ├── developer.rst
│       ├── documentation.rst
│       ├── examples.rst
│       ├── features.rst
│       ├── images
│       │   ├── spherical_coordinates.svg
│       │   └── spherical_coordinates.tex
│       ├── index.rst
│       ├── install.rst
│       ├── license.rst
│       ├── logo
│       │   └── NeuroM.jpg
│       ├── migration.rst
│       ├── morph_check.rst
│       ├── morph_stats.rst
│       ├── quickstart.rst
│       ├── spherical_coordinates.rst
│       ├── tutorial.rst
│       └── validation.rst
├── examples
│   ├── boxplot.py
│   ├── density_plot.py
│   ├── end_to_end_distance.py
│   ├── extract_distribution.py
│   ├── features_graph_table.py
│   ├── get_features.py
│   ├── histogram.py
│   ├── iteration_analysis.py
│   ├── nl_fst_compat.py
│   ├── plot_somas.py
│   ├── radius_of_gyration.py
│   ├── section_ids.py
│   └── soma_radius_fit.py
├── LICENSE.txt
├── MANIFEST.in
├── neurom
│   ├── apps
│   │   ├── annotate.py
│   │   ├── cli.py
│   │   ├── config
│   │   │   ├── morph_check.yaml
│   │   │   └── morph_stats.yaml
│   │   ├── __init__.py
│   │   ├── morph_check.py
│   │   └── morph_stats.py
│   ├── check
│   │   ├── __init__.py
│   │   ├── morphology_checks.py
│   │   ├── morphtree.py
│   │   ├── neuron_checks.py
│   │   └── runner.py
│   ├── core
│   │   ├── dataformat.py
│   │   ├── __init__.py
│   │   ├── morphology.py
│   │   ├── neuron.py
│   │   ├── population.py
│   │   ├── soma.py
│   │   └── types.py
│   ├── exceptions.py
│   ├── features
│   │   ├── bifurcationfunc.py
│   │   ├── bifurcation.py
│   │   ├── __init__.py
│   │   ├── morphology.py
│   │   ├── neurite.py
│   │   ├── population.py
│   │   ├── sectionfunc.py
│   │   └── section.py
│   ├── geom
│   │   ├── __init__.py
│   │   └── transform.py
│   ├── __init__.py
│   ├── io
│   │   ├── __init__.py
│   │   └── utils.py
│   ├── morphmath.py
│   ├── neurom.egg-info
│   │   ├── dependency_links.txt
│   │   ├── entry_points.txt
│   │   ├── PKG-INFO
│   │   ├── requires.txt
│   │   ├── SOURCES.txt
│   │   └── top_level.txt
│   ├── stats.py
│   ├── utils.py
│   ├── view
│   │   ├── dendrogram.py
│   │   ├── __init__.py
│   │   ├── matplotlib_impl.py
│   │   ├── matplotlib_utils.py
│   │   └── plotly_impl.py
│   └── viewer.py
├── PKG-INFO
├── pylintrc
├── pyproject.toml
├── README.md
├── setup.cfg
├── setup.py
└── tox.ini

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only include=["neurom"] seems to be doing the trick..

@eleftherioszisis eleftherioszisis merged commit 7e41691 into master Mar 27, 2024
5 checks passed
@eleftherioszisis eleftherioszisis deleted the check-packaging branch March 27, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants