make a few methods static, add set_blocksize helper#8
Open
ryan-williams wants to merge 4 commits intoBlosc:masterfrom
Open
make a few methods static, add set_blocksize helper#8ryan-williams wants to merge 4 commits intoBlosc:masterfrom
ryan-williams wants to merge 4 commits intoBlosc:masterfrom
Conversation
Member
|
Hi @ryan-williams . Sorry about the delay; I had seen your PR, but then forgot about it until today. This looks good to me. Could you update the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also:
I released a fork from lasersonlab/JBlosc/ as
org.lasersonlab:jblosc:1.0.1for my immediate use downstream, but these are the upstream-worthy bits