Fix address stats with re-orged history entries #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junderw
pushed a commit
to junderw/electrs
that referenced
this pull request
Dec 12, 2023
…workflow ops: Add a Docker image builder workflow
shesek
force-pushed
the
202309-fix-address-stats
branch
from
05be1c5
to
9488afa
Compare
There might be history entries where the txid ended up confirming at a different block height following a re-org. Before this fix, these entries would get counted twice, once with the initial re-orged confirmation height, then again with the final confirmation height. See mempool/electrs#12.
shesek
force-pushed
the
202309-fix-address-stats
branch
from
9488afa
to
74e93df
Compare
|
If there are no objections, I will go ahead and merge this PR. Note that there might still be cached script stats entries with incorrect values in db. Fixing this would require deleting the cache database at |
|
utACK 74e93df, code review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be history entries where the txid ended up confirming at a different block height following a re-org. Before this fix, these entries would get counted twice, once with the initial re-orged confirmation height, then again with the final confirmation height.
See mempool/electrs#12.