Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates interns 2022 #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updates interns 2022 #73

wants to merge 2 commits into from

Conversation

shannona
Copy link
Contributor

@shannona shannona commented Aug 2, 2022

These are some updates from our interns that seem to be mainly UI related. Please take a look and see if they're appropriate & mature for merging?

@shannona
Copy link
Contributor Author

shannona commented Aug 2, 2022

@nochiel would you be able to take a look at this.

Also, at Dependabot alerts: https://github.com/BlockchainCommons/spotbit/security/dependabot

Thank you!

@nochiel
Copy link
Contributor

nochiel commented Aug 4, 2022

@nochiel would you be able to take a look at this.

Yes, I'll review it this weekend.

Also, at Dependabot alerts: https://github.com/BlockchainCommons/spotbit/security/dependabot

Thanks. Will do.

Copy link
Contributor

@nochiel nochiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deymow Am I correct that these commits only rearrange the directory structure for the web front-end?

If that's the case then I think we should wait until you've got it running. Right now I don't think this PR is sufficient to merge if you haven't got the web front end running.

Also, I think it would be good if you posted some screenshots of the frontend in the PR and documented your improvements in the commit messages so that it's easy for us to tell what you're trying to achieve in each commit.

Btw.

  • Why is static/assets/ts/main.ts in the PR yet it's empty?
  • Should static/assets/images/logos/spotbit-logo.psd be in the repository?

@nochiel
Copy link
Contributor

nochiel commented Aug 9, 2022

@nochiel would you be able to take a look at this.

Also, at Dependabot alerts: https://github.com/BlockchainCommons/spotbit/security/dependabot

The alerts are fixed in #76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants