Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple solc-paths #31

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

zetherz
Copy link

@zetherz zetherz commented Jul 26, 2018

Space-delimited, i.e. --solc-paths="my_solidity_path=my_actual_path my_solidity_path2=my_actual_path2"

Using slice notation.

@XertroV
Copy link

XertroV commented Aug 13, 2018

Why don't you use the format solc already has for this? I don't use aliases like that but does path1=realPath1,path2=realPath2, work?

@XertroV
Copy link

XertroV commented Aug 13, 2018

Why don't you use the format solc already has for this? I don't sue aliases like that but does path1=realPath1,path2=realPath2, work?

Also, not sure your patch would work b/c currently you either need to manually patch core.py or use --solc-paths "--allow-paths ./p1,./p2,

@zetherz
Copy link
Author

zetherz commented Aug 13, 2018

@XertroV no, that didn't work for me, hence this PR. See also #5.

Not sure what your second point means. This patch works perfectly for me as-is without either of the two kludges you suggested. I've been using it for a while. Please feel free to actually try it and let me know if you still have issues with it.

@XertroV
Copy link

XertroV commented Aug 13, 2018

@zetherz replied to that issue

The second point was talking about using a command like: solidity_flattener --solc-paths "--allow-paths a=b,c=d,"

Note: I patched core.py manually on my machine so I don't add in --allow-paths at the beginning, but saw it referenced in another issue/PR today, so hopefully works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants