Stack memory alignment & misc clean-ups #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies, when working on the previous patch, I missed that the stack needed to be aligned to 32-bit addresses, not 16-bit addresses due to the use of pointers in the stack. I've got that fixed now and I haven't been able to break it again.
I've also made some small clean-ups with respect to AVR as the default EEPROM config option and avr/pgmspace.h include do not play nice with the ESP8266. I've minor #ifdefs to help make sensible choices.
One last thing, I've tidied the comments a little bit so that the style is a little bit more consistent - this is mostly just capitalisation at the start of the comment.