Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OnClick and OnMouse actions for Canvas #84

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

KristofferStrube
Copy link

As described in issue #83

@KristofferStrube
Copy link
Author

I accidentally continued working with other things on the same branch. That has been reverted now. I'm new to making Pull Requests.

Copy link

@ummerland ummerland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, perfect addition to the Canvas!
There are some other Events that can also be added however: OnPointerDown, OnPointerUp, OnPointerMove

@Thaina
Copy link
Contributor

Thaina commented Feb 7, 2021

Did ondblclick was included?

@KristofferStrube
Copy link
Author

Hey @ummerland I must have missed a notification at some point, sorry. But I added the handlers you described now. And added the handler that @Thaina requested as well together with the OnContextMenu handler.

@ummerland
Copy link

Very nice, thanks @KristofferStrube

Copy link

@ummerland ummerland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good and practical addition, clean code

@Thaina
Copy link
Contributor

Thaina commented Feb 8, 2021

@ummerland Do we have any chance this would be updated in nuget? Or we need to build this ourselves? It seem this repo don't get any updated for a whole year

@attilah
Copy link
Member

attilah commented Feb 15, 2021

Sorry for the late update, we coming to this package and get review the feature PR and also update the package to .NET 5.0, thanks for the contrib.

@KristofferStrube
Copy link
Author

@attilah regarding the conflict with blazor.extensions.canvas.js which is auto-generated. Which version should be used? Doesn't seem like it would actually need to change with the modifications I've made to the project.

@KristofferStrube
Copy link
Author

@tbm0115 I had some problems with my merge as you can see, but there are no conflicts now. You can just squash my commits.

@neilgd
Copy link

neilgd commented Feb 20, 2022

Hi,

I'm wondering if this change made it into the release, or maybe it got lost somewhere?

I get an error System.InvalidOperationException: Object of type 'Blazor.Extensions.Canvas.BECanvas' does not have a property matching the name 'onmousedown'

@KristofferStrube
Copy link
Author

Hey @neilgd,
No this never got merged into the master branch.

@sethfduke
Copy link

Hey @neilgd, No this never got merged into the master branch.

Any chance this is going to be merged at some point? Been sitting here for quite a while.

mludlum added a commit to mludlum/Canvas that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants