Add option to customize the hashed password field #31
+72
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
BlakeWilliams
left a comment
BlakeWilliams
left a comment
There was a problem hiding this comment.
Thanks for opening this!
Overall it looks good, but I had one question about how to organize the new option in terms of functions.
lib/auth/bcrypt.ex
Outdated
| ``` | ||
| """ | ||
| def hash_password(changeset) do | ||
| def hash_password(changeset, opts \\ %{}) do |
Owner
There was a problem hiding this comment.
What are your thoughts on splitting this into two functions? The first could have the same name/arity as the original method and the second could match on your field name?
e.g.
def hash_password(changeset) do
hash_password(changeset, field_name: :hashed_password)
end
def hash_password(changeset, %{"field_name" => field_name})
# existing logic in PR
endThat would also let us focus the documentation for each logical case.
Author
There was a problem hiding this comment.
That looks even better and would not introduce breaking changes related to the arity, nice!
I'll make these changes :)
Author
|
@BlakeWilliams sorry about taking some much time to make those changes, but they're done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, awesome project!
When working on a project I found the necessity to give other name to the hashed password field, so I thought of writing this PR.