Skip to content

Conversation

@pandablue0809
Copy link
Member

@pandablue0809 pandablue0809 requested a review from ihomp September 7, 2025 19:42
<Link href="/services/account-settings/">Account Settings</Link>
<Link href="/services/nft-mint">{t('menu.services.nft-mint')}</Link>
<Link href="/username">{t('menu.usernames')}</Link>
<Link href="/xrp-xah-taxes">{t('menu.services.tax-reports')}</Link>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be in the same PR?

@ihomp
Copy link
Member

ihomp commented Sep 14, 2025

@Anna15170221 can you help testing this one and give your feedback

@Anna15170221
Copy link
Contributor

@ihomp @pandablue0809
my findings

  • let's use the same button style as we have for the whole project
Screenshot 2025-09-15 at 14 46 29
  • Instead of Upgade to Pro let's use the same button Register or Sign in
Screenshot 2025-09-15 at 13 30 03
  • when I log in i got this error
Screenshot 2025-09-15 at 13 33 19
  • not visible text for dark theme
Screenshot 2025-09-15 at 14 39 35
  • I think we need to add short explanations about the fields we offer to fill (rate, tick size and so on)

  • it's not clear what I am supposed to do to continue, the buttons are not active

Screenshot 2025-09-15 at 14 53 25
  • for Xahau network we shouldn't show XRPL we should show Xahau

@pandablue0809
Copy link
Member Author

@ihomp
i fixed it. plz review again. 🙏

@pandablue0809 pandablue0809 requested a review from ihomp September 16, 2025 20:58
@ihomp
Copy link
Member

ihomp commented Sep 28, 2025

@Anna15170221 can you please test again, thx

@Anna15170221
Copy link
Contributor

@pandablue0809 @ihomp

  • The "Configure Cold/HOT Wallet" button is always inactive. Should it be like this?
Screen.Recording.2025-09-30.at.16.14.12.mov
  • if I press back to previous step, it erases some fields on the previous page (the address for example)

  • We have Transfer rate in both Cold and Hot Wallet configurations - should it be like this? we shouldn't mention it in Hot Wallet Configs, I guess. https://xrpl.org/docs/tutorials/how-tos/use-tokens/issue-a-fungible-token. And it can be 0-1%, so the user can't be allowed to enter something different. @ihomp Am i right?

  • I think we are missing the explanation for settings, for tick size and others.

  • If on the previous step we specified that the limit can be 1000, why do we mention that it can be 1000 or higher?

Screenshot 2025-09-30 at 17 20 55
  • Step 3: I think we need to make it possible to create a trustline right away on this page. Otherwise it's a gap in the whole process and the user will need to go somewhere else to create the trustline. And after setting the trustline, the user will send the token from one wallet to another. - He also should have an opportunity to do it right away on this page as the part of the process.
    At this moment Step 3 seems to be not finalised at all and the buttons are inactive.
Screenshot 2025-09-30 at 17 27 59

@pandablue0809
Copy link
Member Author

@Anna15170221 @ihomp
i fixed it.
and if i input the wallet address, the "Configure Cold/Host Wallet" is active.
plz review again. 🙏

@ihomp
Copy link
Member

ihomp commented Oct 10, 2025

@Anna15170221 pls test when you have time

@Anna15170221
Copy link
Contributor

@pandablue0809
I have a question. Did you manage to successfully issue a token using this page?
https://bithomp.com/en/learn/issue-a-token - I would recommend to read this text, it's short and written in simple words, probably this will somehow help you to proceed with the page.

  1. On Step 1 let's add the options to enter: the Token Name, The Token Ticker, The Token Description and upload the image. This will go before setting the supply type.
  2. Transfer rate is % of total supply that will be transferred to hot wallet - that's is not correct, I assume, this is a percentage fee charged on payments made in this token. Change the wording.
  3. If I entered the address the button to config is still disabled, It becomes enabled only if I sign in. We should explain this point to the user otherwise it's not clear. And this should be clear for the user what he is doing and with which wallet he must be signed in.
  • the user sets the cold wallet - he is signed in with the cold wallet.
  • the user sets the hot wallet and sets the trustline to cold wallet - he is signed in with the hot wallet.
  • the user sends token from cold wallet to hot - he is signed with the cold wallet.
    In the future to make it easier to the user we will enable the fast switch between accounts (we already have the ticket for it).
    Currently the user is signed in and you suggest to sign all transactions with one and the same wallet.
  1. Currently after pressing config button it actually gives no data no refs in data error.
Screenshot 2025-10-10 at 15 28 27 5. The idea of setting the regular keys is not correct. It should not actually be like this.
  1. Currently the page seems broken.
Screenshot 2025-10-11 at 10 26 26
  1. Kindly test the page yourself before the sending for approval.
    Thank you.

@pandablue0809
Copy link
Member Author

@ihomp @Anna15170221
i fix errors.
plz review again. 🙏

@ihomp
Copy link
Member

ihomp commented Nov 21, 2025

@Anna15170221 can you please test again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants