-
Notifications
You must be signed in to change notification settings - Fork 25
Allow to open viewer in a separate window #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow to open viewer in a separate window #548
Conversation
|
@Anna15170221 can you test this one and write your suggestions? from me: it seems a lot of code was copy pasted from a different component, we shouldn't copy-paste the code, we need to extract it and reuse it.. that way we will keep the code maintanable.
|
|
ihomp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there is a lot of copy-pasted code that needs to be extracted and reused.
|
@pandablue0809 http://localhost:3000/en/nft/00083A9836EC5BC756007990B29DBFC81F45460ED8B8583A6442C30600000069 - I tested on this one |
|
@ihomp Slava, popups scrolling for fixed objects - what do you mean here? |
|
@ihomp |
@pandablue0809 chenaged css for the search block, so the search block on other pages can appear over some popuup windows like choosinga. token or when signing transactions, or when scrolling on a pages, some elemnts can be under the bar or over the bar.. it's dangerous to change such parameters without proper testing on different pages with different scenarious |
@Anna15170221 can you test again please |
…-separate-window-on-nft-page
…-separate-window-on-nft-page
|
@ihomp |
|
@pandablue0809 |
|
@Anna15170221 @ihomp |
|
@pandablue0809 @ihomp |
ihomp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of copy-pasted functions and code.
You can not copy-paste the same function within the same app, they need to be extracted as functions and reused.
…-separate-window-on-nft-page
|
@ihomp |
ihomp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check how you used styles in the other pages you did:
/pages/nft-collection
/pages/objects
/pages/services/account-settings
Please use it here in the same way.
|
@ihomp |
|
@Anna15170221 can you please test again, please |
|
@ihomp for me looks ok. |
| )} | ||
| {modelUrl && defaultTab === 'model' && ( | ||
| <> | ||
| {modelState === 'loading' && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this part go?
| )} | ||
| {videoUrl && defaultTab === 'video' && ( | ||
| <> | ||
| {loadingImage(nft)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why nft is deleted?
|
There are many things affected by this PR: We need to test:
We need to make sure we need to make sure we have proper loading states
We need to make sure we show errors for failing loading images @Anna15170221 @pandablue0809, please send me some examples where you've tested, so I can check too. |



Issue
Make possible to open the integrated viewer in a separate window (/nft page).