Skip to content

Add link to learn page and update footer layout #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pavel-fokin
Copy link
Contributor

@pavel-fokin pavel-fokin commented Jun 17, 2025

This PR depends on #351.

  • Add link to Learn section to the footer.
  • Change footer layout as it started breaking for longer article names.

The single column, centered layout on mobile should be better for readability and UX.

Mobile view

image

13 inch screen

image

@ihomp
Copy link
Member

ihomp commented Jun 17, 2025

@pavel-fokin pls resolve =)

@pavel-fokin pavel-fokin force-pushed the learn-hub-and-footer branch from fcb28c6 to 8a24df7 Compare June 17, 2025 13:14
@pavel-fokin
Copy link
Contributor Author

@ihomp resolved

@ihomp
Copy link
Member

ihomp commented Jun 17, 2025

In production we have it like that:
Screenshot 2025-06-17 at 18 42 45
Screenshot 2025-06-17 at 18 43 17
Screenshot 2025-06-17 at 18 42 59

I like that all social icons are in one row, I like that address is not broken in the middle and not squished—on any screen size

@ihomp
Copy link
Member

ihomp commented Jun 17, 2025

In this PR
Screenshot 2025-06-17 at 18 47 05

  • all the columns do not fit in the same row on 14''
  • the social icons slit into two lines
  • the text is broken a bit, like Bithomp AB - now on two different lines.. it lookes squized, even though there are space on the left.
Screenshot 2025-06-17 at 18 46 48

@ihomp
Copy link
Member

ihomp commented Jun 17, 2025

About the mobile:
I don't mind "The single column, centered layout on mobile should be better for readability and UX.", looks good !

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't squeeze address and social icons

would be nice to fit all the columns on one line as before.. we don't have to have links for each article in the footer - if the names are long now, we can have just link to "Learn" and people can see the articles there

@pavel-fokin pavel-fokin force-pushed the learn-hub-and-footer branch from 8a24df7 to 8a76c9d Compare June 18, 2025 08:43
@pavel-fokin
Copy link
Contributor Author

@ihomp I updated width and paddings for brand element, so socials and address don't break. Links still colapse nicely. Pls, take a look.

@ihomp
Copy link
Member

ihomp commented Jun 18, 2025

  1. It seems the PR breaks our designed layout a bit, as it changes the paddings.
    It nice to keep the same paddings as we used to have, so they stay the same everywhere.

here what we have without PR
Screenshot 2025-06-18 at 14 42 14

here with this PR
Screenshot 2025-06-18 at 14 42 21

  1. The text with company details is now align to left, not to right as it was designed. I think its nice to keep it aligned to the right as it was designed.

  2. this how it was in Russian

Screenshot 2025-06-18 at 14 52 43

This how it is now.

Screenshot 2025-06-18 at 14 52 28
  • social icons are into lines, blocks are in two lines.
    I think the way we had it was better.

May be we should only update how it looks on mobile, without touching it for the desktop? Otherwise we can spend quite some time for it. It's not a big issue.

@ihomp
Copy link
Member

ihomp commented Jun 18, 2025

Before
Screenshot 2025-06-18 at 14 57 41

Now
Screenshot 2025-06-18 at 14 57 54

I also liked the way before better..

centered text looks good on mobile only.

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we shouldn't touch how it looks on the desktop.. may be we can just add the link and make text centered on mobile.

@pavel-fokin pavel-fokin mentioned this pull request Jun 19, 2025
@pavel-fokin
Copy link
Contributor Author

@ihomp see #370 for minimal changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants