-
Notifications
You must be signed in to change notification settings - Fork 23
Add link to learn page and update footer layout #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@pavel-fokin pls resolve =) |
fcb28c6
to
8a24df7
Compare
@ihomp resolved |
About the mobile: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't squeeze address and social icons
would be nice to fit all the columns on one line as before.. we don't have to have links for each article in the footer - if the names are long now, we can have just link to "Learn" and people can see the articles there
8a24df7
to
8a76c9d
Compare
@ihomp I updated width and paddings for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be we shouldn't touch how it looks on the desktop.. may be we can just add the link and make text centered on mobile.
This PR depends on #351.
The single column, centered layout on mobile should be better for readability and UX.
Mobile view
13 inch screen