ios: fix tight margins on fullscreen View #3367
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonsirsha
force-pushed
the
ios-fix-tight-margins-on-fullscreen-views
branch
from
3dc62db to
3566bcb
Compare
benma
requested changes
May 26, 2025
We previously added space but only the top. Added bottom spacing now as well. Regarding the "X" button was because it's an absolute posiitoned item, so it didn't respect the top padding. Thus added extra space for its `top` property here.
shonsirsha
force-pushed
the
ios-fix-tight-margins-on-fullscreen-views
branch
from
3566bcb to
e32a723
Compare
|
@benma , my bad. It was a typo / syntax error (added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously added space but only the top.
Added bottom spacing now as well.
Regarding the "X" button was because it's an absolute posiitoned
item, so it didn't respect the top padding. Thus added extra
space for its
topproperty here.