OP-556 - Adding Sylius 2.0 support #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkalon
force-pushed
the
OP-556
branch
2 times, most recently
from
5c2e7f8 to
ec6194d
Compare
senghe
reviewed
Jan 7, 2025
Comment on lines
+38
to
+50
| "polishsymfonycommunity/symfony-mocker-container": "^1.0", | ||
| "robertfausk/behat-panther-extension": "^1.1", | ||
| "sylius-labs/coding-standard": "^4.4", | ||
| "sylius-labs/suite-tags-extension": "~0.2", | ||
| "sylius/mailer-bundle": "^1.8 || ^2.0@beta", | ||
| "sylius/sylius-rector": "^2.0", | ||
| "symfony/browser-kit": "^6.4 || ^7.1", | ||
| "symfony/debug-bundle": "^6.4 || ^7.1", | ||
| "symfony/dependency-injection": "^6.4 || ^7.1", | ||
| "symfony/dotenv": "^6.4 || ^7.1", | ||
| "symfony/http-client": "^6.4 || ^7.1", | ||
| "symfony/intl": "^6.4 || ^7.1", | ||
| "symfony/web-profiler-bundle": "^6.4 || ^7.1" |
There was a problem hiding this comment.
It's require-dev, not conflicts.
src/Resources/assets/admin/entry.js
Outdated
There was a problem hiding this comment.
Finally, It seems, these files can be removed
| @@ -0,0 +1,7 @@ | |||
| framework: | |||
| mailer: | |||
| dsn: 'null://null' | |||
Comment on lines
+1
to
+7
| sylius_crud_routes: | ||
| resource: 'sylius.routing.loader.crud_routes_attributes' | ||
| type: service | ||
|
|
||
| sylius_routes: | ||
| resource: 'sylius.routing.loader.routes_attributes' | ||
| type: service |
There was a problem hiding this comment.
Routes from Sylius Standard
| use Symfony\Component\Form\FormBuilderInterface; | ||
| use Symfony\Component\Validator\Constraints\NotBlank; | ||
|
|
||
| class FrankMartinShippingGatewayType extends AbstractType |
senghe
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behat
PHPSpec
ECS fixes
Plugin files update
Added Sylius 2.0 support
Updated composer.json
Updated packege.json and webpack.config.js
--- added Stimulus controller
--- updated webpack.config.js, assets path and added product-entry.js
Updated bundles.php
Updated routes
Updated Kernel.php
Updated configs - removed unnecessary files and
--- updated security.yaml
--- added mailer.yaml