Fix some issues to work in sylius 1.12 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
approved these changes
Jul 12, 2023
| @@ -1,5 +1,3 @@ | |||
| {% include '@SyliusUi/_javascripts.html.twig' with {'path': 'assets/shop/js/app.js'} %} | |||
There was a problem hiding this comment.
these lines should not be removed, but replaced with:
{{ encore_entry_script_tags('shop-entry', null, 'shop') }}
Author
There was a problem hiding this comment.
But we didn't need the shop javascript here. all the code is plain javascript here without dependencies.
But i can readd it if we need it.
| ```yaml | ||
| sylius_shop_checkout_start: | ||
| path: /{_locale}/checkout-start | ||
| path: / |
| { | ||
| return new Response( | ||
| $this->templating->render('BitBagSyliusAmazonPayPlugin:AmazonPay:amazonPayStart.html.twig') | ||
| $this->templating->render('@BitBagSyliusAmazonPayPlugin/AmazonPay/amazonPayStart.html.twig') |
|
Why not merged? Still something to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
i've tried to fix some issues which prevent the plugin to work in my sylius 1.12 environment.
I've removed the jquery dependency in amazonPayStart.html.twig to avoid loading of full Javascript Entrypoint.