[WIP] feat(core): replace server-side api calls with client-side #231
Conversation
✅ Deploy Preview for defimetascan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lykalabrada
changed the title
lykalabrada
changed the title
| @@ -246,7 +271,6 @@ export async function getServerSideProps( | |||
| return { | |||
| props: { | |||
| data: { | |||
| block, | |||
| blockTransactions: { | |||
There was a problem hiding this comment.
Can we get block details from server side and blockTransactions we can get on client side, This is because when we will share url on any platform then we will need block details first (SEO point of view)
| }; | ||
| }); | ||
|
|
||
| setLatestBlocks(sliced); |
There was a problem hiding this comment.
Can we assign this setLatestBlocks before getting txResults
There was a problem hiding this comment.
Also we can separate loading for txn and blocks? what you think?
| }: { | ||
| txDetails: TransactionI; | ||
| }) { | ||
| export default function Transaction() { |
There was a problem hiding this comment.
As this is for specific txn, i will suggest to keep this server side only
DFC-136 Performance: Improve speed of page redirects
In the current meta.defiscan.live, most of our API calls are done from the server side which is causing initial load to be slow and page switching to be clunky.
|
What this PR does / why we need it:
In the current meta.defiscan.live, most of our API calls are done from the server side which is causing initial load to be slow and page switching to be clunky.
In this PR most API calls have been moved to the client side, this would allow our pages to be rendered right away before calling the APIs
Which issue(s) does this PR fixes?:
Fixes DFC-136, #234
Additional comments?:
This PR is only a rough draft, to compare and see if the site clunkiness will improve. The following are still pending:
/transaction/id,/block/id, ...)Developer Checklist: