Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dex): integrate stab-fee api [Awaiting Confirmation] #1770

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat(dex): integrate stab-fee api [Awaiting Confirmation] #1770

wants to merge 5 commits into from

Conversation

lykalabrada
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Sample Links & Screenshots:

Link:

Desktop Screenshot
Mobile Screenshot

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on multiple web browsers
  • Tested responsiveness (e.g, iPhone, iPad, Desktop)
  • No console errors
  • Unit tests*
  • Added e2e tests*

veralygit and others added 2 commits March 20, 2023 18:15
@veralygit
fix(ui-ux): fix the dex poolpairid page (#1768)
3b9f361 
fix(ui-ux): fix the dex poolpairid page where value for csETH-dETH is not showing
@kyleleow
chore: update net supply info text
c6c8488
@netlify
Copy link

netlify bot commented Mar 21, 2023 •
edited
Loading

❌ Deploy Preview for defi-scan failed.

Name Link
🔨 Latest commit 121161d
🔍 Latest deploy log https://app.netlify.com/sites/defi-scan/deploys/6419580528e6120007c5bb9d

@kyleleow
Copy link
Member

Lyka can you update @waveshq/walletkit to ^0.41.0 in this PR? Then change target branch to rc/1.10.0

@lykalabrada lykalabrada changed the base branch from main to rc/1.10.0 March 22, 2023 03:17
@lykalabrada lykalabrada changed the title feat(dex): integrate stab-fee api feat(dex): integrate stab-fee api [Awaiting Confirmation] Mar 22, 2023
Base automatically changed from rc/1.10.0 to main March 22, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chloezxyy chloezxyy Awaiting requested review from chloezxyy chloezxyy will be requested when the pull request is marked ready for review chloezxyy is a code owner

@fullstackninja864 fullstackninja864 Awaiting requested review from fullstackninja864 fullstackninja864 will be requested when the pull request is marked ready for review fullstackninja864 is a code owner

@pierregee pierregee Awaiting requested review from pierregee pierregee will be requested when the pull request is marked ready for review pierregee is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area/dex area/store kind/feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lykalabrada @kyleleow @veralygit