Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deploy-preview): to remove governance/create from deploy preview url (WIP) #1720

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

kyleleow
Copy link
Member

@kyleleow kyleleow commented Feb 9, 2023

What this PR does / why we need it:

  • NOT READY, do not merge
  • To remove governance/create from deploy preview url

Additional comments:

Findings:

  • adding apple/create/index.page.tsx and apple/index.page.tsx page will fix the url
  • moving governance/create/index.page.tsx to governance/create.page.tsx does not fix ❌
  • removing governance/create/index.page.tsx will fix the url
  • renaming governance/create.page.tsx to governance/wonderful.page.tsx will change the deploy preview url to governance/wonderful
  • removing all content within governance/wonderful.page.tsx does not fix ❌
  • renaming governance/create/index.page.tsx to governance/apple/index.page.tsx will change url to governance/apple

@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for defi-scan ready!

Name Link
🔨 Latest commit 4ba6efd
🔍 Latest deploy log https://app.netlify.com/sites/defi-scan/deploys/63e49370510edf00072ddc8b
😎 Deploy Preview https://deploy-preview-1720--defi-scan.netlify.app/governance/apple
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyleleow kyleleow changed the title poc: create apple/create file chore(deploy-preview): to remove governance/create from deploy preview url (WIP) Feb 9, 2023
@github-actions github-actions bot added the kind/chore Non feature change label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant