Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactome using utils #17

Merged
merged 13 commits into from
Jun 25, 2024
Merged

Reactome using utils #17

merged 13 commits into from
Jun 25, 2024

Conversation

yoavkt
Copy link
Collaborator

@yoavkt yoavkt commented Jun 24, 2024

Modify Reactome to use task retrieval

@yoavkt yoavkt requested a review from edenjenzohar June 24, 2024 12:48
@yoavkt
Copy link
Collaborator Author

yoavkt commented Jun 24, 2024

I added a print and verified that this works on local files as well.

@yoavkt yoavkt requested a review from edenjenzohar June 24, 2024 14:32
@edenjenzohar
Copy link
Collaborator

I dont fully understand if these scripts have been checked for both of the possible instances: downloading the data and using local data. This is essential to make sure this script works correctly.

@yoavkt
Copy link
Collaborator Author

yoavkt commented Jun 25, 2024

Ok, I removed the redundant script and removed it. I checked the Reactome_tasks_creation script with the addition of local and web-based tasks.

Copy link
Collaborator

@edenjenzohar edenjenzohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@yoavkt yoavkt merged commit efa7837 into main Jun 25, 2024
6 checks passed
@yoavkt yoavkt deleted the reactome_using_utils branch June 25, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants