Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

508 for collections/harvestparams.php #741

Open
wants to merge 2 commits into
base: Development
Choose a base branch
from

Conversation

NikitaSalikov
Copy link
Collaborator

Accessibility mode:

Before:

Screenshot 2023-11-30 at 4 32 59 PM

After:

Screenshot 2023-11-30 at 4 33 59 PM

Condensed mode:

Before:

Screenshot 2023-11-30 at 4 39 53 PM

After:

Screenshot 2023-11-30 at 4 35 23 PM

Changes Made:

  • added sticky buttons element on the right. (!)Work in Progress
  • removed duplicate buttons
  • removed extra spaces in elevation low/high and collection data start/end (btw the latter one has a "-" which could be extra, but I still left it)
  • added skip links after each section
  • added doctype and lang
  • fixed font-size to relevant
  • fixed labels

Pull Request Checklist:

Pre-Approval

  • There is a description section in the pull request that details what the proposed changes do. It can be very brief if need be, but it ought to exist.
  • [N/A] Hotfixes should be branched off of the master branch and squash and merged back into the master branch.
  • Features and backlog bugs should be merged into the Development branch, NOT master
  • All new text is preferably internationalized (i.e., no end-user-visible text is hard-coded on the PHP pages)
  • [N/A] There are no linter errors
  • New features have responsive design (i.e., look aesthetically pleasing both full screen and with small or mobile screens)
  • Symbiota coding standards have been followed
  • [N/A] If any files have been reformatted (e.g., by an autoformatter), the reformat is its own, separate commit in the PR
  • Comment which GitHub issue(s), if any does this PR address
  • If this PR makes any changes that would require additional configuration of any Symbiota portals outside of the files tracked in this repository, make sure that those changes are detailed in this document.

Post-Approval

  • It is the code author's responsibility to merge their own pull request after it has been approved
  • If this PR represents a merge into the Development branch, remember to use the squash & merge option
  • If this PR represents a merge from the Development branch into the master branch, remember to use the merge option
  • If this PR represents a hotfix into the master branch, a subsequent PR from master into Development should be made merge option (i.e., no squash).
  • If the dev team has agreed that this PR represents the last PR going into the Development branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock the Development branch to prevent accidental merges while QA takes place. Follow the release protocol here.
  • Don't forget to delete your feature branch upon merge. Ignore this step as required.

Thanks for contributing and keeping it clean!

…ded skip links after each section, fixed spacing, removed duplicate buttons, added sticky buttons element
@NikitaSalikov NikitaSalikov marked this pull request as ready for review November 30, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants