Update ispalindromic
#304
Merged
Update ispalindromic
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand the documentation to explain that it is palindromic with respect to the reverse-complement. Also implement a fast-path for 2-bit nucleotides.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 90.89% 90.91% +0.01%
==========================================
Files 31 31
Lines 2395 2400 +5
==========================================
+ Hits 2177 2182 +5
Misses 218 218
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Seelengrab
reviewed
Mar 22, 2024
src/biosequence/predicates.jl
Outdated
| return false | ||
| end | ||
| end | ||
| _ispalindromic(seq) |
There was a problem hiding this comment.
Did you mean to insert 4-spaces instead of a TAB-character here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the documentation to explain that it is palindromic with respect to the reverse-complement. Also implement a fast-path for 2-bit nucleotides.
See #303 - thanks, @Seelengrab