Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fatal for faulty XCode installation #353

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add fatal for faulty XCode installation #353

wants to merge 2 commits into from

Conversation

TobiasDuswald
Copy link
Contributor

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vasvav
Copy link
Contributor

vasvav commented Feb 16, 2025

dear @LukasBreitwieser and @TobiasDuswald,
I've checked the commits of this PR and I think we are clear to go, while resolving the above conflict seems straightforward.
dear @FonsRademakers,
what do you think? are you ok to merge (after accommodating the conflict in the cmake/external/ROOT.cmake file) and, thus, finalise this PR?
cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasBreitwieser LukasBreitwieser LukasBreitwieser left review comments

@FonsRademakers FonsRademakers Awaiting requested review from FonsRademakers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TobiasDuswald @vasvav @LukasBreitwieser