Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samtools-1.10 #369

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ychenbioinfo
Copy link
Contributor

add samtools-1.10

@biocontainers-bot
Copy link
Collaborator

Found an existing bioconda package for this software (https://bioconda.github.io/recipes/samtools/README.html), is this the same, then you should update the recipe in bioconda to avoid duplicates.

@biocontainers-bot
Copy link
Collaborator

No samtools/1.7.0/test-cmds.txt (test file) present, skipping tests

LABEL about.license_file="https://github.com/samtools/samtools/blob/develop/LICENSE"
LABEL about.license="SPDX:MIT"
LABEL about.tags="Genomics"
LABEL extra.identifiers.biotools="SAM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is bio.tools not samtools (https://bio.tools/samtools) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link shows the tool is samtools, but it's not the home page of samtools. I am not sure what do you need here. I saw you used both LABEL extra.identifiers.biotools="SAM" and LABEL extra.binary = "SAMTOOLS" before.

@osallou
Copy link
Contributor

osallou commented Jun 25, 2020

Biotools id is samtools, not sam , incorrectly used in older releases

@biocontainers-bot
Copy link
Collaborator

Found an existing bioconda package for this software (https://bioconda.github.io/recipes/samtools/README.html), is this the same, then you should update the recipe in bioconda to avoid duplicates.

@biocontainers-bot
Copy link
Collaborator

No samtools/1.7.0/test-cmds.txt (test file) present, skipping tests


################## METADATA ######################

ARG software_version=1.7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an eror here, version is 1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants