This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
Real Dart enums over FFI #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Lesches
commented
Jun 14, 2024
There was a problem hiding this comment.
All changes to this file can be reverted and are just for testing.
|
Already fixed by #12 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Waiting for ffigen 13.0.0 to release
Thanks to dart-lang/native#1202 by yours truly, FFI now returns an actual Dart enum instead of an integer representing the value of the C enum. This simplifies our API, code, and gets rid of magic numbers completely.