Skip to content

issue 276 allow non-integer inputs to FO analyzer #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2025
Merged

issue 276 allow non-integer inputs to FO analyzer #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ced40e
issue 276 allow non-integer inputs to FO analyzer
nholik Jan 8, 2025
fb74451
Merge branch 'develop' into issue-276-allow-non-integer-fo-values-in-…
primo-ppcg Oct 24, 2025
9230cd6
Also allow for ^FT
primo-ppcg Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/BinaryKits.Zpl.Viewer/CommandAnalyzers/FieldOriginZplCommandAnalzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,23 @@ public override ZplElementBase Analyze(string zplCommand)
{
string[] zplDataParts = this.SplitCommand(zplCommand);

int tmpint;
decimal tmpdec;
int x = 0;
int y = 0;

if (zplDataParts.Length > 0 && int.TryParse(zplDataParts[0], out tmpint))
if (zplDataParts.Length > 0 &&
decimal.TryParse(zplDataParts[0], out tmpdec) &&
int.MinValue <= tmpdec && tmpdec <= int.MaxValue)
{
x = tmpint;
x = decimal.ToInt32(tmpdec);
}

if (zplDataParts.Length > 1 && int.TryParse(zplDataParts[1], out tmpint))

if (zplDataParts.Length > 1 &&
decimal.TryParse(zplDataParts[1], out tmpdec) &&
int.MinValue <= tmpdec && tmpdec <= int.MaxValue)
{
y = tmpint;
y = decimal.ToInt32(tmpdec);
}

if (zplDataParts.Length > 2)
Expand Down
12 changes: 7 additions & 5 deletions src/BinaryKits.Zpl.Viewer/CommandAnalyzers/FieldTypesetZplCommandAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public override ZplElementBase Analyze(string zplCommand)
{
string[] zplDataParts = this.SplitCommand(zplCommand);

int tmpint;
decimal tmpdec;
int x = 0;
int y = 0;
bool useDefaultPosition = false;
Expand All @@ -25,9 +25,10 @@ public override ZplElementBase Analyze(string zplCommand)
}
else
{
if (int.TryParse(zplDataParts[0], out tmpint))
if (decimal.TryParse(zplDataParts[0], out tmpdec) &&
int.MinValue <= tmpdec && tmpdec <= int.MaxValue)
{
x = tmpint;
x = decimal.ToInt32(tmpdec);
}
else
{
Expand All @@ -38,9 +39,10 @@ public override ZplElementBase Analyze(string zplCommand)

if (zplDataParts.Length > 1 && !string.IsNullOrEmpty(zplDataParts[1]))
{
if (int.TryParse(zplDataParts[1], out tmpint))
if (decimal.TryParse(zplDataParts[1], out tmpdec) &&
int.MinValue <= tmpdec && tmpdec <= int.MaxValue)
{
y = tmpint;
y = decimal.ToInt32(tmpdec);
}
else if (!useDefaultPosition)
{
Expand Down
Loading