Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: related query search in RelatedDto #596

Closed
wants to merge 3 commits into from

Conversation

qwert2001qwert-alex
Copy link

Without this fix, Serializer will not work correctly.

https://restify.binarcode.com/api/serializer

Copy link

what-the-diff bot commented Dec 29, 2023

PR Summary

  • Change in Argument Order in str_contains() function
    In the RelatedDto.php file, developers modified the sequence in which input parameters were given to a function. This is just a simple adjustment in the way we submit data to the program, which may help us avoid potential program-breaking errors in the future.

@binaryk
Copy link
Collaborator

binaryk commented Dec 30, 2023

Thank you @qwert2001qwert-alex! Please pull from 8.x and make sure tests passes, because this fix will break the serializer. There is a test that proves it works, check: test_can_manually_serialize_repository. I added this PR that might help you testing: #597

@binaryk binaryk self-requested a review December 30, 2023 12:50
@qwert2001qwert-alex
Copy link
Author

qwert2001qwert-alex commented Dec 30, 2023

Is there something wrong. When I reproduce this in my project, it requires the suggested changes. I'm trying to figure it out.

@binaryk
Copy link
Collaborator

binaryk commented Jan 5, 2024

Thank you, will close the PR for now.

@binaryk binaryk closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants