Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property meta for easier to customize #595

Closed
wants to merge 1 commit into from
Closed

Add property meta for easier to customize #595

wants to merge 1 commit into from

Conversation

robin-dongbin
Copy link
Contributor

Not used internally

Copy link

what-the-diff bot commented Dec 16, 2023

PR Summary

  • Introduction of New Property to Field Class
    A new attribute named meta has been integrated into the Field class. This enhancement will expand the current capability of the Field class and provide additional meta-information for each field.

@binaryk
Copy link
Collaborator

binaryk commented Dec 30, 2023

Thank you @robin-dongbin. Can you explore more:

  1. can we use the src/Traits/Metable trait? As we do it the filter src/Filters/Filter.php:22
  2. what's the benefit of meta if we don't serialize it? Is it only for backend purposes? Check the src/Fields/Field.php:532, we serialize it for the filter src/Filters/Filter.php:252

@robin-dongbin
Copy link
Contributor Author

In fact, I was initially going to use it for the backend, to define some metadata and serialize it myself and filter some useless attributes for my project.
But now I realize that my needs are more complex and defining source data alone doesn't completely solve my problem. Maybe I should extend from Field and customize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants