Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented NestedWillPopScope for later handling PopScopes #221

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PcolBP
Copy link

@PcolBP PcolBP commented Aug 23, 2021

I've implemented NestedWillPopScope with null-safety.
Separated so if later need to be used no need to implement all data from package just this file.
Updated dependency as well.

All behaviour from before stays the same.

Potential fixes of:

This PR contains no breaking change.

PcolBP added 3 commits August 20, 2021 13:49
Implement NestedWillPopScope
Updated dependencies
Separate file to in nested widgets import only this one without other stuff
@ashishbeck
Copy link

Can we get this PR merged, please? It seems like a really great solution to a relatively small but difficult problem

@PcolBP
Copy link
Author

PcolBP commented Oct 21, 2021

@ashishbeck as a temporary solution before this PR will be merged, you can fork my repository and then use it in your project like this in pubspec.yaml :

persistent_bottom_nav_bar:
   git:
     url: https://github.com/PcolBP/PersistentBottomNavBar.git

@khanhtruongq
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants