Removing reflection use in NetUtils #2426
Conversation
NetworkInterface.getByIndex was introduced in JDK 7 and is included in current baseline.
| collectNetworkInterfacesByIndex(list); | ||
|
|
||
| if (!list.isEmpty()) { | ||
| return Collections.enumeration(list); |
There was a problem hiding this comment.
This "Java 7 preview" block of code made the runtime return at this line when running Java 7 or higher.
I believe the next block was for JDK 6 and earlier only, making that a tautology on the current baseline.
Should I go ahead and remove it too?
There was a problem hiding this comment.
I mean, it only returned here if the list was non-empty. Which doesn't seem like it's guaranteed even still, so I'd say it's far from tautological.
Most of the time the code will never get this far, period. It'll return the valid list produced by getNetworkInterfaces() on line 526 (524 in your PR), none of the code past that will even execute, and all will be right with the world.
But on some system where getNetworkInterfaces() fails, can we say for sure that getByIndex() won't fail as well? Especially when the code is just guessing indices.
It's clear from the docs that the getByIndex() method was meant to be used by code that already had a known valid index, most likely retrieved by previously calling .getIndex() on an interface object and storing it somewhere. And the docs explicitly refuse to guarantee anything about the index values themselves, other than that they're integers >= 0. So there's nothing stopping some implementation from using high and/or randomized index values that the getByIndex() approach won't ever find.
In which case, guessing names could theoretically still work as an absolute last-resort fallback.
There was a problem hiding this comment.
I was right the first time, with what I said above. Ignore any followups, nothing to see here. 🙄 (Not my night.)
Removed this forward compatibility code as the Android SDK level 15 / JDK8 API is the current baseline.
Wrapped it in a separate method.
NetworkInterface.getByIndex(int) was introduced with Java 7.