Add (and/or stub out) many missing features and fix several bugs. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably a bad idea, but I have no idea why yet.
This should be refactored into a setter so these values aren't hard-coded.
Conflicts: UIKit/Classes/UIView.m
This fixes an issue with UIWebView where its contents would be flipped vertically.
Caveat: The text layer (independent of its superview) should probably still be “not hidden” even when the text field is hidden. However, without adding additional plumbing to make UITextLayer update its NSViews, this is a reasonable solution to make UITextLayer create an NSView when unhidden.
This disables the [UIView _needsDidAppearOrDisappear] by always making it equal YES. To be honest, I don’t understand what its purpose is, but this appears to cause no side effects.
Store the database in ~/Library/Application Support/{App name}/WebKit/LocalStorage so it’s sandboxed to the application and persistent across multiple runs.
I'm basing this on the behaviour described in this SO post: http://stackoverflow.com/questions/5317417/how-do-you-set-the-tab-order-in-ios
Replaces previous commit with a better solution.
|
Any plan to accept this pull request? |
|
There hasn't been any activity from the project maintainers in a few years I've been maintaining the toushay/Chameleon fork, which this pull request But in the meantime, please feel free to use the toushay/Chameleon fork.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Toushay, we recently ported a large iOS codebase to OS X via Chameleon. In the process, we encountered several differences between iOS UIKit and Chameleon. This pull request is a compilation of all the changes we needed to make to Chameleon to get our application behaving properly.
Sorry for lumping a bunch of unrelated changes into one pull request. Let me know if you'd like me to split it apart or exclude any commits.