Suggestion PR to utilize LibCombatLogging-1.0
for combat logging.
#1113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal behind
LibCombatLogging-1.0
is to try alleviate issues where multiple addons with various configurations will start/stop combat logging.Sometimes one addon is setup to primarily log let's say raiding, but another might want to log keystones or Torghast or some other content, what often happens is when one addon loads in where it wants to log, it turns on logging, meanwhile the other addon might use the moment to turn it off since that addon isn't supposed to be logging here anyway, and this causes logging start/stop issues for the user.
The suggested solution is a library where the community can start/stop logging, but the library will properly turn it off once every other addon that started logging has stopped logging, this way we ensure we don't lose any combat data.