Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Paul,
Before I go ahead and added more flexibilities and features for click events, I thought I'd review with you some of the changes on
SVG
andSVGBase
.I added couple of methods for us to fetch all elements at a specific location, which can be restricted to only elements with ids. We could move
containsCoords
intoBox
as it's more of a helper method forBox
.Just exposing
getElementsAt
from base.Rather than fetching for ids, I thought we might as well put them in
idToElementMap
while creating the render tree. We could change this togetIdToElementMap().put(id, obj)
. Moreover we can then exposegetIdToElementMap()
.Let me know what you think.
Ishan