Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paredit Multicursor - Testing Utils - textNotation changes and diagnostic utils #2419

Merged
merged 8 commits into from
Mar 8, 2024

Conversation

riotrah
Copy link
Member

@riotrah riotrah commented Mar 2, 2024

What has changed?

Prepares testing utilites for multiple selection tests, editing some existing tests to fit, while preserving their single-cursor semantics. (re)introduces the diagnostic Calva commands for creating textNotations from vscode buffers and vice versa.

  • This requires changing the textNotation syntax somewhat ->
    • | for single cursor is still fine, but subsequent cursors are |1, |2, …|n, and selections now >,>1, >|2, …>n & <|…<n, instead of |>|
  • Also introduces some tests for the textnotation stuff.
  • The above changes required some extensions to ModelEditSelection and EditableModel.

Fixes #2417
FIxes #2418
Addresses #610

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
    • Referenced the issue I am fixing/addressing in a commit message for the pull request.
      • If I am fixing the issue, I have used GitHub's fixes/closes syntax
      • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit 2f80256
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/65eb08313512020008a37354
😎 Deploy Preview https://deploy-preview-2419--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@riotrah riotrah changed the base branch from published to dev March 2, 2024 23:58
@riotrah riotrah requested a review from PEZ March 2, 2024 23:58
@riotrah
Copy link
Member Author

riotrah commented Mar 2, 2024

@PEZ I only made the GH issues as I was drafting the PR, so no commit msg references :/ - I'll get there 😅

@riotrah riotrah self-assigned this Mar 7, 2024
@riotrah riotrah added paredit Paredit and structural editing Calva Development Related to the development experience of Calva itself. diagnostics Tooling for debugging Calva or REPL issues labels Mar 7, 2024
@riotrah riotrah changed the title Multicursor - Testing Utils - textNotation changes and diagnostic utils Paredit Multicursor - Testing Utils - textNotation changes and diagnostic utils Mar 7, 2024
@riotrah riotrah force-pushed the wip/rayat/multicursor/prep/refactor-testing-utils branch from 10a5410 to 296abe7 Compare March 8, 2024 05:43
@PEZ PEZ force-pushed the wip/rayat/multicursor/prep/refactor-testing-utils branch from 296abe7 to 2f80256 Compare March 8, 2024 12:44
@PEZ PEZ merged commit 519fa75 into dev Mar 8, 2024
5 checks passed
@PEZ PEZ deleted the wip/rayat/multicursor/prep/refactor-testing-utils branch March 8, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Calva Development Related to the development experience of Calva itself. diagnostics Tooling for debugging Calva or REPL issues paredit Paredit and structural editing
Projects
None yet
2 participants