-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paredit Multicursor - Testing Utils - textNotation changes and diagnostic utils #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@PEZ I only made the GH issues as I was drafting the PR, so no commit msg references :/ - I'll get there 😅 |
15 tasks
riotrah
added
paredit
Paredit and structural editing
Calva Development
Related to the development experience of Calva itself.
diagnostics
Tooling for debugging Calva or REPL issues
labels
Mar 7, 2024
riotrah
changed the title
Multicursor - Testing Utils - textNotation changes and diagnostic utils
Paredit Multicursor - Testing Utils - textNotation changes and diagnostic utils
Mar 7, 2024
riotrah
force-pushed
the
wip/rayat/multicursor/prep/refactor-testing-utils
branch
from
March 8, 2024 05:43
10a5410
to
296abe7
Compare
PEZ
force-pushed
the
wip/rayat/multicursor/prep/refactor-testing-utils
branch
from
March 8, 2024 12:44
296abe7
to
2f80256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Calva Development
Related to the development experience of Calva itself.
diagnostics
Tooling for debugging Calva or REPL issues
paredit
Paredit and structural editing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
Prepares testing utilites for multiple selection tests, editing some existing tests to fit, while preserving their single-cursor semantics. (re)introduces the diagnostic Calva commands for creating textNotations from vscode buffers and vice versa.
|
for single cursor is still fine, but subsequent cursors are |1, |2, …|n, and selections now >,>1, >|2, …>n & <|…<n, instead of |>|Fixes #2417
FIxes #2418
Addresses #610
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.Added to or updated docs in this branch, if appropriatenpm run prettier-format
)npm run eslint
before creating your PR, or runnpm run eslint-watch
to eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik