Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multicursor - Refactors - EditableDocument uses selections #2414

Merged
merged 11 commits into from
Mar 2, 2024

Conversation

riotrah
Copy link
Member

@riotrah riotrah commented Mar 1, 2024

What has changed?

Addresses #610. Another step in refactoring all cursor/selection related code to assume multiple selections without affecting user functionality. Dependent on #2413.

  • Altered the .selection property of EditableDocument to be an array, .selections instead
  • Updated all call sites, including tests

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
    • Referenced the issue I am fixing/addressing in a commit message for the pull request.
      • If I am fixing the issue, I have used GitHub's fixes/closes syntax
      • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@riotrah riotrah requested a review from PEZ March 1, 2024 06:06
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit 3cbd653
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/65e36b9c6e3cd40008bfb05f
😎 Deploy Preview https://deploy-preview-2414--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@riotrah riotrah changed the title Multicursor - Refactor - EditableDocument uses selections Multicursor - Refactors - EditableDocument uses selections Mar 1, 2024
@PEZ PEZ changed the base branch from published to dev March 1, 2024 07:24
@PEZ
Copy link
Collaborator

PEZ commented Mar 1, 2024

You checked two boxes, and nonetheless. 😄

image

I think there is an open issue about multicursor paredit that you can refer this PR too. We usually use language as “Adderessing #XXXX” when we are not closing or fixing issue with some commits.

@riotrah riotrah marked this pull request as ready for review March 2, 2024 09:55
@riotrah riotrah merged commit c888eb4 into dev Mar 2, 2024
4 of 5 checks passed
@riotrah riotrah deleted the wip/rayat/use-selections-in-editable-document branch March 2, 2024 18:11
@riotrah riotrah self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants