Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wombat COVID rules to OpenFisca #191
base: master
Are you sure you want to change the base?
Add wombat COVID rules to OpenFisca #191
Changes from 3 commits
ee6da1b
e0e2d02
2ac9026
0914de6
839cc4a
335c6d1
e366d4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a bit strange to have a space in this key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are both failing in CI - with the errors:
AssertionError: In test 'Sole trader, does not have IRD number, not eligible for wage subsidy', in file '/root/project/openfisca_aotearoa/tests/social_security/covid_19_wage_subsidy.yaml', covid_19_wage_subsidy__eligibility@2020-6: [0.] differs from 1.0 with an absolute margin [1.] > 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As below - some debugging with @JacOng17 reveals that it's because of the missing
located_in_NZ
parameter. If you make those changes, the tests should pass @asgharkazi @sarafalamakiThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests here don't seem to match the name - have made suggestions on the relevant lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.